Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add thickness and pitch again to csv geometry writing #1663

Merged

Conversation

benjaminhuth
Copy link
Member

This is needed by the Exa.TrkX data reader. This was once part of ACTS, but was removed (not sure why).

@benjaminhuth benjaminhuth added Impact - Minor Nuissance bug and/or affects only a single module Component - Examples Affects the Examples module labels Nov 9, 2022
@benjaminhuth benjaminhuth added this to the next milestone Nov 9, 2022
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #1663 (0fd295f) into main (d73c4ff) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1663   +/-   ##
=======================================
  Coverage   48.46%   48.46%           
=======================================
  Files         384      384           
  Lines       21071    21071           
  Branches     9702     9702           
=======================================
  Hits        10213    10213           
  Misses       4130     4130           
  Partials     6728     6728           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

📊 Physics performance monitoring for 0fd295f

🟥 ERROR The result has missing elements!
This is likely a physmon job failure

Full report
CKF: ❌ seeded, ❌ truth smeared, ❌ truth estimated
IVF: ❌ seeded, ❌ truth smeared, ❌ truth estimated
❌ Ambiguity resolution
❌ Truth tracking

Vertexing ❌

❌ Vertexing vs. mu

❌ IVF seeded

❌ IVF truth_smeared

❌ IVF truth_estimated

CKF ❌

❌ CKF seeded

❌ CKF truth_smeared

❌ CKF truth_estimated

Ambiguity resolution ❌

❌ seeded

Truth tracking ❌

❌ Truth tracking

@benjaminhuth benjaminhuth changed the title feature: Add thickness and pitch again to csv geometry writing feat: Add thickness and pitch again to csv geometry writing Nov 9, 2022
@kodiakhq kodiakhq bot merged commit 599dd86 into acts-project:main Nov 9, 2022
@github-actions github-actions bot removed the automerge label Nov 9, 2022
@benjaminhuth benjaminhuth deleted the feature/add-thickness-pitch-to-csv branch November 9, 2022 23:16
@paulgessinger paulgessinger modified the milestones: next, v21.1.0 Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Impact - Minor Nuissance bug and/or affects only a single module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants