chore: clang tidy headers

[andiwand]

fix clang tidy for header files. also includes fixes for clang-tidy warnings from @paulgessinger

replacement for #1440

[codecov]

Codecov Report

Merging #1662 (4ee5a16) into main (b018119) will increase coverage by 0.05%.
The diff coverage is 58.57%.

@@            Coverage Diff             @@
##             main    #1662      +/-   ##
==========================================
+ Coverage   48.53%   48.58%   +0.05%     
==========================================
  Files         383      382       -1     
  Lines       21004    21059      +55     
  Branches     9649     9644       -5     
==========================================
+ Hits        10194    10232      +38     
- Misses       4130     4147      +17     
  Partials     6680     6680              

Impacted Files	Coverage Δ
Core/include/Acts/EventData/MultiTrajectory.hpp	69.41% <ø> (ø)
...e/include/Acts/EventData/VectorMultiTrajectory.hpp	58.51% <ø> (ø)
Core/include/Acts/Geometry/BoundarySurfaceT.hpp	58.33% <ø> (ø)
Core/include/Acts/Geometry/ConeVolumeBounds.hpp	50.00% <ø> (ø)
...ore/include/Acts/Geometry/CylinderVolumeBounds.hpp	49.15% <ø> (ø)
Core/include/Acts/Geometry/SurfaceArrayCreator.hpp	42.85% <ø> (ø)
...re/include/Acts/Geometry/TrapezoidVolumeBounds.hpp	16.66% <ø> (ø)
...ude/Acts/MagneticField/detail/SmallObjectCache.hpp	79.06% <ø> (-0.48%)	⬇️
...ore/include/Acts/Material/VolumeMaterialMapper.hpp	42.85% <ø> (ø)
...re/include/Acts/Propagator/CovarianceTransport.hpp	0.00% <ø> (ø)
... and 88 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

📊 Physics performance monitoring for 4ee5a16

Full report
CKF: seeded, truth smeared, truth estimated
IVF: seeded, truth smeared, truth estimated
Ambiguity resolution
Truth tracking (Kalman Filter)
Truth tracking (GSF)

Vertexing

Vertexing vs. mu

IVF seeded

IVF truth_smeared

IVF truth_estimated

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

[andiwand]

@paulgessinger looks like cmake refuses to compile header files

[paulgessinger]

Did you check if the headers end up in compile_commands.json?

[andiwand]

Did you check if the headers end up in compile_commands.json?

yeah I check - sadly they don't show up. I guess cmake is refusing to build these files because of their extension

[paulgessinger]

Maybe we need something like: https://stackoverflow.com/questions/59716373/compile-headers-for-errors-using-cmake ?

[andiwand]

Maybe we need something like: https://stackoverflow.com/questions/59716373/compile-headers-for-errors-using-cmake ?

hmm but don't we include our headers in some of our source files anyway?

[paulgessinger]

Maybe some we don't? I don't actually fully understand this tbh.

[andiwand]

Maybe some we don't? I don't actually fully understand this tbh.

so the source file for a header file does not seem to do the trick either... I need to check how this is supposed to work with header files again

[andiwand]

looks like this works now. https://gitlab.cern.ch/acts/ci-bridge/-/jobs/25840196 is failing because of the html report generation

[andiwand]

this is passing now @paulgessinger @benjaminhuth if you want to take a look. I think it would be good to get this in soon to prevent merge conflicts as this is touching a lot of code in different places

[benjaminhuth]

Let's get this in!