Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: required for new ITk geometry #1653

Merged
merged 3 commits into from
Nov 9, 2022
Merged

Conversation

timadye
Copy link
Contributor

@timadye timadye commented Nov 4, 2022

New element names in buildITkGeometry for updated ATLAS ITk and HGTD geometry, ATLAS-P2-RUN4-01-00-00.
This supports the new geometry TGeo root file just added to the acts-itk repo.

ValueError: Incorrect binning configuration found: Number of configurations does not match number of protolayers in subvolume Pixel::Pixel. Quitting.

@timadye timadye added the 🚧 WIP Work-in-progress label Nov 4, 2022
@timadye timadye added this to the next milestone Nov 4, 2022
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

📊 Physics performance monitoring for cf50e4c

🟥 ERROR The result has missing elements!
This is likely a physmon job failure

Full report
CKF: ❌ seeded, ❌ truth smeared, ❌ truth estimated
IVF: ❌ seeded, ❌ truth smeared, ❌ truth estimated
❌ Ambiguity resolution
❌ Truth tracking

Vertexing ❌

❌ Vertexing vs. mu

❌ IVF seeded

❌ IVF truth_smeared

❌ IVF truth_estimated

CKF ❌

❌ CKF seeded

❌ CKF truth_smeared

❌ CKF truth_estimated

Ambiguity resolution ❌

❌ seeded

Truth tracking ❌

❌ Truth tracking

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #1653 (cf50e4c) into main (8a1d7d6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1653   +/-   ##
=======================================
  Coverage   48.46%   48.46%           
=======================================
  Files         384      384           
  Lines       21071    21071           
  Branches     9702     9702           
=======================================
  Hits        10213    10213           
  Misses       4130     4130           
  Partials     6728     6728           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@timadye timadye marked this pull request as ready for review November 9, 2022 14:50
@timadye timadye removed the request for review from paulgessinger November 9, 2022 16:28
Copy link
Contributor

@tboldagh tboldagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thanks. This should help next generations.

@kodiakhq kodiakhq bot merged commit d73c4ff into acts-project:main Nov 9, 2022
@github-actions github-actions bot removed the automerge label Nov 9, 2022
@paulgessinger paulgessinger modified the milestones: next, v21.1.0 Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants