-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: required for new ITk geometry #1653
Conversation
📊 Physics performance monitoring for cf50e4c
Full report Vertexing ❌❌ Vertexing vs. mu ❌ IVF seeded ❌ IVF truth_smeared ❌ IVF truth_estimated CKF ❌❌ CKF seeded ❌ CKF truth_smeared ❌ CKF truth_estimated Ambiguity resolution ❌❌ seeded Truth tracking ❌❌ Truth tracking |
Codecov Report
@@ Coverage Diff @@
## main #1653 +/- ##
=======================================
Coverage 48.46% 48.46%
=======================================
Files 384 384
Lines 21071 21071
Branches 9702 9702
=======================================
Hits 10213 10213
Misses 4130 4130
Partials 6728 6728 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. Thanks. This should help next generations.
New element names in
buildITkGeometry
for updated ATLAS ITk and HGTD geometry,ATLAS-P2-RUN4-01-00-00
.This supports the new geometry TGeo root file just added to the
acts-itk
repo.Note that without this PR, the latest version of
acts-itk
(tagATLAS-P2-RUN4-01-00-00
) will not work.acts-itk
tagATLAS-P2-23
can be used instead.With this PR,
acts-itk
master
(or tagATLAS-P2-RUN4-01-00-00
) should be used.The error message from
itk.py
indicating a version mismatch is: