Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: duplicated configuration in itk.py #1651

Merged
merged 3 commits into from
Nov 4, 2022
Merged

fix: duplicated configuration in itk.py #1651

merged 3 commits into from
Nov 4, 2022

Conversation

LuisFelipeCoelho
Copy link
Member

@LuisFelipeCoelho LuisFelipeCoelho commented Nov 4, 2022 •
edited
Loading

I noticed that zBinEdges is defined twice in itk.py
This PR removes the unnecessary definition
but I am not sure if this can be considered a bug

@LuisFelipeCoelho LuisFelipeCoelho added this to the next milestone Nov 4, 2022
@LuisFelipeCoelho LuisFelipeCoelho added Bug Something isn't working Impact - Minor Nuissance bug and/or affects only a single module Component - Examples Affects the Examples module labels Nov 4, 2022
@LuisFelipeCoelho LuisFelipeCoelho marked this pull request as ready for review November 4, 2022 09:43
AJPfleger
AJPfleger approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@codecov
Copy link

codecov bot commented Nov 4, 2022 •
edited
Loading

Codecov Report

Merging #1651 (aecf3a4) into main (03b2283) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1651   +/-   ##
=======================================
  Coverage   48.54%   48.54%           
=======================================
  Files         384      384           
  Lines       21042    21042           
  Branches     9693     9693           
=======================================
  Hits        10214    10214           
  Misses       4106     4106           
  Partials     6722     6722

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Nov 4, 2022 •
edited
Loading

📊 Physics performance monitoring for aecf3a4

Full report
CKF: seeded, truth smeared, truth estimated
IVF: seeded, truth smeared, truth estimated
Ambiguity resolution
Truth tracking

Vertexing

IVF seeded

IVF truth smeared

IVF truth estimated

CKF

seeded

truth smeared

truth estimated

Ambiguity resolution

seeded

Truth tracking

Truth tracking

@kodiakhq kodiakhq bot merged commit ac6f337 into acts-project:main Nov 4, 2022
@github-actions github-actions bot removed the automerge label Nov 4, 2022
@paulgessinger paulgessinger modified the milestones: next, v21.1.0 Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AJPfleger AJPfleger AJPfleger approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Component - Examples Affects the Examples module Impact - Minor Nuissance bug and/or affects only a single module
Projects
None yet
Milestone
v21.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@LuisFelipeCoelho @AJPfleger @paulgessinger