Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: examples restore vertexing track selector #1644

Merged

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Nov 1, 2022

#1579 remove the track selector from addVertexing which is still required. see #1636

#1588 should clean this up a little

@andiwand andiwand added the Component - Examples Affects the Examples module label Nov 1, 2022
@andiwand andiwand added this to the next milestone Nov 1, 2022
@andiwand andiwand requested a review from timadye November 1, 2022 15:07
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #1644 (98677cb) into main (65ea889) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1644   +/-   ##
=======================================
  Coverage   48.58%   48.58%           
=======================================
  Files         381      381           
  Lines       20833    20833           
  Branches     9557     9557           
=======================================
  Hits        10122    10122           
  Misses       4108     4108           
  Partials     6603     6603           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

📊 Physics performance monitoring for 98677cb

Full report
CKF: seeded, truth smeared, truth estimated
IVF: seeded, truth smeared, truth estimated
Ambiguity resolution
Truth tracking

Vertexing

IVF seeded

IVF truth smeared

IVF truth estimated

CKF

seeded

truth smeared

truth estimated

Ambiguity resolution

seeded

Truth tracking

Truth tracking

@kodiakhq kodiakhq bot merged commit e1b8ebb into acts-project:main Nov 1, 2022
@github-actions github-actions bot removed the automerge label Nov 1, 2022
@paulgessinger paulgessinger modified the milestones: next, v21.0.0 Nov 3, 2022
@andiwand andiwand deleted the examples-restore-vertexing-track-selector branch January 24, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants