Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configurable weight factor for longitudinal impact parameter in seed weight #1632

Merged

Conversation

LuisFelipeCoelho
Copy link
Member

This allows us to configure the weight factor for longitudinal impact parameter in seed weight

@LuisFelipeCoelho LuisFelipeCoelho added this to the next milestone Oct 27, 2022
@LuisFelipeCoelho LuisFelipeCoelho added Component - Core Affects the Core module Improvement Changes to an existing feature Component - Examples Affects the Examples module labels Oct 27, 2022
@github-actions
Copy link

github-actions bot commented Oct 27, 2022

📊 Physics performance monitoring for 0af3c7c

🟥 ERROR The result has missing elements!
This is likely a physmon job failure

Full report
CKF: ❌ seeded, ❌ truth smeared, ❌ truth estimated
IVF: ❌ seeded, ❌ truth smeared, ❌ truth estimated
❌ Ambiguity resolution
❌ Truth tracking

Vertexing ❌

❌ Vertexing vs. mu

❌ IVF seeded

❌ IVF truth_smeared

❌ IVF truth_estimated

CKF ❌

❌ CKF seeded

❌ CKF truth_smeared

❌ CKF truth_estimated

Ambiguity resolution ❌

❌ seeded

Truth tracking ❌

❌ Truth tracking

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #1632 (0af3c7c) into main (472459a) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1632      +/-   ##
==========================================
- Coverage   48.49%   48.49%   -0.01%     
==========================================
  Files         384      384              
  Lines       21059    21060       +1     
  Branches     9694     9694              
==========================================
  Hits        10213    10213              
- Misses       4122     4123       +1     
  Partials     6724     6724              
Impacted Files Coverage Δ
Core/include/Acts/Seeding/SeedFilter.ipp 0.00% <0.00%> (ø)
Core/include/Acts/Seeding/SeedFilterConfig.hpp 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LuisFelipeCoelho LuisFelipeCoelho marked this pull request as ready for review October 28, 2022 08:08
@kodiakhq kodiakhq bot merged commit f3814fa into acts-project:main Nov 8, 2022
@github-actions github-actions bot removed the automerge label Nov 8, 2022
@LuisFelipeCoelho LuisFelipeCoelho deleted the longitudinal-impact-weightFactor branch November 10, 2022 16:09
@paulgessinger paulgessinger modified the milestones: next, v21.1.0 Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Improvement Changes to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants