Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: variable r range in orthogonal seeding #1621

Merged
merged 16 commits into from
Nov 15, 2022
Merged

feat: variable r range in orthogonal seeding #1621

merged 16 commits into from
Nov 15, 2022

Conversation

LuisFelipeCoelho
Copy link
Member

@LuisFelipeCoelho LuisFelipeCoelho commented Oct 25, 2022 •
edited
Loading

This was included in the orthodox seeding in #1084

@LuisFelipeCoelho LuisFelipeCoelho added Component - Core Affects the Core module Improvement Changes to an existing feature Component - Examples Affects the Examples module 🚧 WIP Work-in-progress labels Oct 25, 2022
@LuisFelipeCoelho LuisFelipeCoelho added this to the next milestone Oct 25, 2022
@github-actions
Copy link

github-actions bot commented Oct 25, 2022 •
edited
Loading

📊 Physics performance monitoring for eca75ae

Full report
CKF: seeded, truth smeared, truth estimated
IVF: seeded, truth smeared, truth estimated
Ambiguity resolution
Truth tracking (Kalman Filter)
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@LuisFelipeCoelho LuisFelipeCoelho changed the title feat: variable r range and r sorting in orthogonal seeding feat: variable r range in orthogonal seeding Nov 9, 2022
@LuisFelipeCoelho LuisFelipeCoelho marked this pull request as ready for review November 9, 2022 13:08
@LuisFelipeCoelho LuisFelipeCoelho removed the 🚧 WIP Work-in-progress label Nov 9, 2022
@codecov
Copy link

codecov bot commented Nov 9, 2022 •
edited
Loading

Codecov Report

Merging #1621 (eca75ae) into main (de75b21) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1621      +/-   ##
==========================================
- Coverage   48.53%   48.51%   -0.02%     
==========================================
  Files         383      383              
  Lines       20980    20986       +6     
  Branches     9641     9644       +3     
==========================================
  Hits        10182    10182              
- Misses       4123     4129       +6     
  Partials     6675     6675
Impacted Files Coverage Δ
Core/include/Acts/Seeding/SeedFinder.ipp 0.00% <0.00%> (ø)
Core/include/Acts/Seeding/SeedFinderConfig.hpp 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit 99380cb into acts-project:main Nov 15, 2022
@LuisFelipeCoelho LuisFelipeCoelho deleted the variable-rMiddle-orthogonal branch November 15, 2022 12:56
@paulgessinger paulgessinger modified the milestones: next, v22.0.0 Dec 21, 2022
CarloVarni pushed a commit to CarloVarni/acts that referenced this pull request Dec 22, 2022
@LuisFelipeCoelho
feat: variable r range in orthogonal seeding (acts-project#1621)
6712b33 
This was included in the orthodox seeding in acts-project#1084
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AJPfleger AJPfleger AJPfleger approved these changes

@stephenswat stephenswat Awaiting requested review from stephenswat

Assignees
No one assigned
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Improvement Changes to an existing feature
Projects
None yet
Milestone
v22.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@LuisFelipeCoelho @AJPfleger @paulgessinger