Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Vertexing mu scan and CI job that creates it #1595

Merged
merged 7 commits into from
Oct 14, 2022

Conversation

paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented Oct 12, 2022

This PR adds a configuration + plotting script for this kind of plot produced by the CI:

vertexing

This currently runs on 25 events, but we might have to tune this to keep the runtime reasonable.

@paulgessinger paulgessinger added this to the next milestone Oct 12, 2022
Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AJPfleger AJPfleger added Improvement Changes to an existing feature Infrastructure Changes to build tools, continous integration, ... automerge labels Oct 12, 2022
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #1595 (9447e70) into main (e2a8df8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1595   +/-   ##
=======================================
  Coverage   48.54%   48.54%           
=======================================
  Files         381      381           
  Lines       20785    20785           
  Branches     9536     9536           
=======================================
  Hits        10090    10090           
  Misses       4112     4112           
  Partials     6583     6583           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@paulgessinger paulgessinger added 🚧 WIP Work-in-progress and removed automerge labels Oct 12, 2022
@paulgessinger
Copy link
Member Author

I made mistake with where I put the output file. Need to fix that before merging.

@paulgessinger paulgessinger removed the 🚧 WIP Work-in-progress label Oct 13, 2022
@paulgessinger
Copy link
Member Author

Ready now, can you reapprove @AJPfleger?

Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thanks for restricting the $ rm in the last commit.

@kodiakhq kodiakhq bot merged commit a3628bd into acts-project:main Oct 14, 2022
paulgessinger added a commit to paulgessinger/acts that referenced this pull request Oct 20, 2022
This PR adds a configuration + plotting script for this kind of plot produced by the CI:

![vertexing](https://user-images.githubusercontent.com/1058585/195329400-3f907dc3-2ad7-4b1d-8276-37a94ccbe377.png)


This currently runs on 25 events, but we might have to tune this to keep the runtime reasonable.
paulgessinger added a commit that referenced this pull request Oct 20, 2022
This PR adds a configuration + plotting script for this kind of plot produced by the CI:

![vertexing](https://user-images.githubusercontent.com/1058585/195329400-3f907dc3-2ad7-4b1d-8276-37a94ccbe377.png)


This currently runs on 25 events, but we might have to tune this to keep the runtime reasonable.
@paulgessinger paulgessinger modified the milestones: next, v21.0.0 Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported to develop/v19.x ✅ Improvement Changes to an existing feature Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants