fix: full chain vertexing [backport #1299 to develop/v19.x] #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix full chain odd vertexing added here #1286 some early discussion here https://mattermost.web.cern.ch/acts/pl/m6psyge3apgcucesrgojeaajny - output track parameters from `TrackFindingAlgorithm` - refactor error handling in `*VertexFinderAlgorithm` - rewire default whiteboard names in python examples - use IVF in `full_chain_odd.py` with 2 muons (which should give us an actual vertex) (cherry picked from commit 884d342)
Codecov Report
@@ Coverage Diff @@
## develop/v19.x #1439 +/- ##
================================================
Coverage ? 47.46%
================================================
Files ? 375
Lines ? 19843
Branches ? 9293
================================================
Hits ? 9418
Misses ? 4055
Partials ? 6370 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
paulgessinger
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 884d342 from #1299.
fix full chain odd vertexing added here #1286
some early discussion here https://mattermost.web.cern.ch/acts/pl/m6psyge3apgcucesrgojeaajny
TrackFindingAlgorithm*VertexFinderAlgorithmfull_chain_odd.pywith 2 muons (which should give us an actual vertex)