fix: Multi-Stepper stepping error in multiple components + refactoring [backport #1339 to develop/v19.x] #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1339) This PR does refactor the `MultiEigenStepperLoop` and fixes a situation, where a few stepping-erros could break the whole propagation. - **Fix:** If some components had stepping errors and all other components where on a surface, the propagation terminated - **Refactor:** - remove internal logger from `MultiEigenStepperLoop` since it is not really configurable from outside - improve `MultiEigenStepperLoop::step` (only construct summary-string in `VERBOSE` mode or on error, remove unnecessary loops and vectors, move things to lambdas, ...) **NOTE:** This does not fix the reason why stepping errors occur in some situations, this (hopefully) will be done in a subsequent PR) (cherry picked from commit 1b973d5)
paulgessinger
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1b973d5 from #1339.
This PR does refactor the
MultiEigenStepperLoopand fixes a situation, where a few stepping-erros could break the whole propagation.MultiEigenStepperLoopsince it is not really configurable from outsideMultiEigenStepperLoop::step(only construct summary-string inVERBOSEmode or on error, remove unnecessary loops and vectors, move things to lambdas, ...)NOTE: This does not fix the reason why stepping errors occur in some situations, this (hopefully) will be done in a subsequent PR)