Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve Python named-type argument checks #1341

Merged
merged 4 commits into from
Jul 28, 2022

Conversation

timadye
Copy link
Contributor

@timadye timadye commented Jul 25, 2022

  • @NamedTypeArgs decorator checks we don't have named-type kwargs following positional args.
  • Improve exception message if we have repeated kwargs

@timadye timadye added this to the next milestone Jul 25, 2022
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #1341 (8bffc40) into main (8c1c406) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1341   +/-   ##
=======================================
  Coverage   47.46%   47.46%           
=======================================
  Files         375      375           
  Lines       19827    19827           
  Branches     9297     9297           
=======================================
  Hits         9410     9410           
  Misses       4033     4033           
  Partials     6384     6384           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kodiakhq kodiakhq bot merged commit b55ec34 into acts-project:main Jul 28, 2022
@paulgessinger paulgessinger modified the milestones: next, v19.6.0 Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants