Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove old DD4hep example detectors #1337

Merged
merged 2 commits into from
Jul 25, 2022

Conversation

paulgessinger
Copy link
Member

In preparation for #1257, this PR removes the old DD4hep detector examples that we don't plan to maintain going forward.

@paulgessinger paulgessinger added this to the next milestone Jul 23, 2022
@codecov
Copy link

codecov bot commented Jul 23, 2022

Codecov Report

Merging #1337 (59e9da3) into main (0fd1e89) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1337   +/-   ##
=======================================
  Coverage   47.47%   47.47%           
=======================================
  Files         375      375           
  Lines       19781    19781           
  Branches     9271     9271           
=======================================
  Hits         9391     9391           
  Misses       4010     4010           
  Partials     6380     6380           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@kodiakhq kodiakhq bot merged commit 4f499d1 into acts-project:main Jul 25, 2022
@paulgessinger paulgessinger deleted the remove-old-dd4hep-examples branch July 25, 2022 09:17
@paulgessinger paulgessinger modified the milestones: next, v19.5.0 Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants