-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Pull more config into physmon script, extend PG eta range to +-4 #1320
ci: Pull more config into physmon script, extend PG eta range to +-4 #1320
Conversation
Clearly this has physmon failures. To me the changes look as expected. I'll update the references once the CI runs through. |
Codecov Report
@@ Coverage Diff @@
## main #1320 +/- ##
=======================================
Coverage 47.42% 47.42%
=======================================
Files 375 375
Lines 19788 19788
Branches 9287 9287
=======================================
Hits 9385 9385
Misses 4021 4021
Partials 6382 6382 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plots look mostly reasonable IMO
the on with the holes looks a bit weird but that might be due to statistical fluctuations? the error bars are quite big. we could check with a different eta distribution, a different seed or more samples. but I don't think it is necessary
I updated the references. I realized now that it's actually pretty hard to put in the correct reference commit SHA, because we squash and merge. No idea if that can be improved. |
yeah I think it is almost impossible. shouldn't be the git history be enough? |
Probably yeah. |
I think this is good now, @andiwand. |
I think for the physmon jobs, given the ODD, it makes little sense to only test particle up to$|\eta| < \pm2$ . This PR adjusts $|\eta| < \pm 4$ .
physmon.py
to include the particle gun configuration so I can customize it to produce particles up to