-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Compute material variance in material mapping #1318
Merged
kodiakhq
merged 8 commits into
acts-project:main
from
Corentin-Allaire:Add_Material_Variance
Jul 26, 2022
Merged
feat: Compute material variance in material mapping #1318
kodiakhq
merged 8 commits into
acts-project:main
from
Corentin-Allaire:Add_Material_Variance
Jul 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corentin-Allaire
added
Component - Core
Affects the Core module
Impact - Minor
Nuissance bug and/or affects only a single module
Component - Examples
Affects the Examples module
Feature
Development to integrate a new feature
labels
Jul 11, 2022
Codecov Report
@@ Coverage Diff @@
## main #1318 +/- ##
==========================================
- Coverage 47.47% 47.43% -0.05%
==========================================
Files 375 375
Lines 19782 19825 +43
Branches 9272 9299 +27
==========================================
+ Hits 9392 9404 +12
- Misses 4010 4033 +23
- Partials 6380 6388 +8
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
robertlangenberg
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automerge
Component - Core
Affects the Core module
Component - Examples
Affects the Examples module
Feature
Development to integrate a new feature
Impact - Minor
Nuissance bug and/or affects only a single module
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in preparation to the one that will add the automatic optimisation of the material mapping.
In this PR we add the option of computing the material variance of each bin. For this, the material mapping need to be run a second time with the material map used as an input. This is control by an option and will thus not affect the performance if not turned on.
This PR also include a new material decorator that can be used as an input for the mapping, this decorator takes in input a map of ID and binning size and use it to create protomaterial for all the mapping surface (this will allow us to change the binning of the material without having to change the input json file).