Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Infrastructure updates, add howto for making a release #1304

Merged
merged 7 commits into from
Jul 8, 2022
Merged

docs: Infrastructure updates, add howto for making a release #1304

merged 7 commits into from
Jul 8, 2022

Conversation

paulgessinger
Copy link
Member

This PR:

  1. Switches to MyST from recommonmark + m2r. The latter are deprecated and MyST should be an improvement all around (directives possible in markdown now)
  2. Adds a navigation point for the existing top level how-to pages
  3. Adds a how-to for making a release

@paulgessinger paulgessinger added this to the next milestone Jul 7, 2022
@paulgessinger paulgessinger changed the title Docs/release docs: Infrastructure updates, add howto for making a release Jul 7, 2022
andiwand
andiwand reviewed Jul 7, 2022
View reviewed changes
docs/howto/release.md Outdated Show resolved Hide resolved
docs/howto/release.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 7, 2022 •
edited
Loading

Codecov Report

Merging #1304 (66cbfa0) into main (0955220) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1304   +/-   ##
=======================================
  Coverage   47.42%   47.42%           
=======================================
  Files         375      375           
  Lines       19788    19788           
  Branches     9287     9287           
=======================================
  Hits         9385     9385           
  Misses       4021     4021           
  Partials     6382     6382

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

andiwand
andiwand reviewed Jul 7, 2022
View reviewed changes
docs/howto/release.md Outdated Show resolved Hide resolved
AJPfleger
AJPfleger approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AJPfleger AJPfleger added Component - Documentation Affects the documentation automerge and removed automerge labels Jul 8, 2022
@paulgessinger @andiwand
Update docs/howto/release.md
2c42e70 
Co-authored-by: Andreas Stefl <[email protected]>
@paulgessinger
Copy link
Member Author

@AJPfleger or @andiwand can you reapprove?

@kodiakhq kodiakhq bot merged commit 0f44907 into acts-project:main Jul 8, 2022
@paulgessinger paulgessinger modified the milestones: next, v19.5.0 Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AJPfleger AJPfleger AJPfleger approved these changes

@andiwand andiwand andiwand approved these changes

Assignees
No one assigned
Labels
automerge Component - Documentation Affects the documentation
Projects
None yet
Milestone
v19.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@paulgessinger @andiwand @AJPfleger