Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixing typo in name of variable and associated methods #1277

Merged
merged 5 commits into from
Jun 7, 2022

Conversation

noemina
Copy link
Contributor

@noemina noemina commented Jun 1, 2022

Self-explanatory title.

FYI: @LuisFelipeCoelho

@noemina noemina added this to the next milestone Jun 1, 2022
@robertlangenberg robertlangenberg added Bug Something isn't working automerge labels Jun 1, 2022
@noemina noemina changed the title fix: Fixing typo in name of variable and associated methods fix: Fixing typo in name of variable and associated methods Jun 1, 2022
@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #1277 (1c0df62) into main (239ece3) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1277   +/-   ##
=======================================
  Coverage   47.48%   47.48%           
=======================================
  Files         376      376           
  Lines       19816    19816           
  Branches     9308     9308           
=======================================
  Hits         9410     9410           
  Misses       4016     4016           
  Partials     6390     6390           
Impacted Files Coverage Δ
Core/include/Acts/Seeding/SeedFinderUtils.ipp 0.00% <0.00%> (ø)
Core/include/Acts/Seeding/SeedfinderConfig.hpp 0.00% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@LuisFelipeCoelho LuisFelipeCoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the changes!

@noemina
Copy link
Contributor Author

noemina commented Jun 7, 2022

Do you see any problem with this PR or can be merged?

@robertlangenberg robertlangenberg enabled auto-merge (squash) June 7, 2022 12:17
@robertlangenberg robertlangenberg self-requested a review June 7, 2022 12:18
@robertlangenberg robertlangenberg merged commit 29f3649 into acts-project:main Jun 7, 2022
@paulgessinger paulgessinger modified the milestones: next, v19.2.0 Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants