fix: Add missing dependency in Exa.TrkX plugin #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminhuth
added
Bug
Codecov Report
@@ Coverage Diff @@
## main #1276 +/- ##
=======================================
Coverage 47.48% 47.48%
=======================================
Files 376 376
Lines 19820 19819 -1
Branches 9308 9308
=======================================
Hits 9412 9412
+ Misses 4018 4017 -1
Partials 6390 6390
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
looks good and makes sense to me |
AJPfleger
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin depends on the boost-headers, which was not explicitly declared in the
CMakeLists.txt. I guess this wasn't detected because in the CI environment the boost headers are installed in the standard include paths...