Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: minimum and maximum values of deltaRMiddleSPRange in check for radial region of interest of middle SP #1261

Merged

Conversation

LuisFelipeCoelho
Copy link
Member

This PR splits deltaRMiddleSPRange into deltaRMiddleMinSPRange and deltaRMiddleMaxSPRange so these values can be configured separately.

@LuisFelipeCoelho LuisFelipeCoelho added this to the next milestone May 19, 2022
@LuisFelipeCoelho LuisFelipeCoelho added Component - Core Affects the Core module Improvement Changes to an existing feature Impact - Minor Nuissance bug and/or affects only a single module labels May 19, 2022
Copy link
Contributor

@noemina noemina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@LuisFelipeCoelho LuisFelipeCoelho changed the title feat: allow for minimum and maximum values of deltaRMiddleSPRange in check for radial region of interest of middle SP feat: minimum and maximum values of deltaRMiddleSPRange in check for radial region of interest of middle SP May 19, 2022
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #1261 (7bc9f03) into main (f026d4b) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1261      +/-   ##
==========================================
- Coverage   47.31%   47.31%   -0.01%     
==========================================
  Files         375      375              
  Lines       19757    19758       +1     
  Branches     9345     9345              
==========================================
  Hits         9348     9348              
- Misses       4020     4021       +1     
  Partials     6389     6389              
Impacted Files Coverage Δ
Core/include/Acts/Seeding/Seedfinder.ipp 0.00% <0.00%> (ø)
Core/include/Acts/Seeding/SeedfinderConfig.hpp 0.00% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@robertlangenberg robertlangenberg merged commit 6eb3937 into acts-project:main May 19, 2022
@LuisFelipeCoelho LuisFelipeCoelho deleted the deltaRMiddleMaxSPRange branch May 19, 2022 13:45
@paulgessinger paulgessinger modified the milestones: next, v19.1.0 May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Impact - Minor Nuissance bug and/or affects only a single module Improvement Changes to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants