feat: add RKN-monitoring to EigenStepper (State and root) #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AJPfleger
added
Feature
Codecov Report
@@ Coverage Diff @@
## main #1256 +/- ##
==========================================
- Coverage 47.64% 47.62% -0.02%
==========================================
Files 375 375
Lines 19624 19627 +3
Branches 9287 9291 +4
==========================================
- Hits 9350 9348 -2
- Misses 3885 3890 +5
Partials 6389 6389
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
asalzburger
approved these changes
May 17, 2022
|
This will need an update of the references, the implementation is simple and I think is good to go, the logging is done by the constrained step, which I think is a better idea than the State! |
|
ping @paulgessinger for the update of the reference hashes |
|
The GPU CI should be fixed by update to recent main. |
|
Hi, as @paulgessinger suggested, a rebase should fix the GPU CI, then we need to update the hashes and this can go in. |
paulgessinger
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds
int nStepTrialsto theState.nStepTrialstracks the number of iterations needed by the stepsize finder (e.g. Runge-Kutta) of the stepper. This should help us to see if the system is stable. Using a constant magnetic field we would expect only 1-2 calls of the RKN-algorithm in order to find the stepsize.