ci: Add full chain test #1247
Merged
ci: Add full chain test #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Do you think it would make sense to integrate this step into |
good point! will do |
|
I integrated into |
andiwand
force-pushed
the
ci/full_chain_odd
branch
from
09d7ef6
to
810e972
Compare
Codecov Report
@@ Coverage Diff @@
## main #1247 +/- ##
=======================================
Coverage 47.89% 47.89%
=======================================
Files 375 375
Lines 19588 19588
Branches 9214 9214
=======================================
Hits 9382 9382
Misses 3822 3822
Partials 6384 6384 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
paulgessinger
approved these changes
May 11, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
May 13, 2022
Follow-up to #1247. This moves the extra invocation of `thirdparty/OpenDataDetector/ci/full_chain_odd.py` into the main `CI/physmon/physmon.py` script where we basically run this chain anyway. This saves some time since we can generate the residual and pulls output from that invocation. I also change the `ActsAnalysisResidualsAndPulls` to be called directly from the python script, so we can reuse the temporary directory from there. This also changes `ActsAnalysisResidualsAndPulls` to return UNIX-style error codes (0: ok, != 0, failure)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
execute
OpenDataDetector/ci/full_chain_odd.pyin CI and compare against referenceCI/physmon/reference/acts_analysis_residuals_and_pulls.rootwithhistcmp