-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding python based full chain example for the ODD #1230
feat: adding python based full chain example for the ODD #1230
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1230 +/- ##
=======================================
Coverage 47.94% 47.94%
=======================================
Files 373 373
Lines 19495 19495
Branches 9152 9152
=======================================
Hits 9347 9347
Misses 3817 3817
Partials 6331 6331 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
I need to change the |eta| range +/- 4 does not make sense |
I have some small updates. Do you mind me pushing to your branch directly? For that I believe you'd have to enable commits from maintainers. |
add argument for output dir
If we are adding option parsing now, should we also do it for full_chain_itk.py, or as a separate PR? Other options to consider:
|
Personally I would restrict it to be the barest possible minimum. I can remove it again if you feel like this should be consistent across the "full chain" examples. |
I had another idea. Could we have a If you agree, I can try to put something like that together. Maybe we don't need the options for this PR, but they are useful as a first step for a separate change. |
I removed the command line arguments and did some cleanup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good :)
This PR adds a python based full chain example for the Open Data Detector, very along the lines of the ITk example.