fix: Match seed finder util .hpp and .ipp types #1214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've discovered that acts-project#1143 introduces a subtle but rather nefarious bug in the seed finder utilities: the const qualifier on one of the types was removed in the .ipp file, but not in the corresponding .hpp file. This means that any code importing the .hpp will gladly compile the code, but because a matching implementation is not present in the .ipp file, it will rely on this implementation being made available at link time. In this particular case, that never happens, and we run into rather hard to debug linking errors. This commit resolves the issue by making sure that the function signatures between the .hpp file and the .ipp file are the same.
stephenswat
added
Bug
|
That is indeed interesting (and not good). Thanks! |
paulgessinger
approved these changes
Mar 30, 2022
|
Ah I'm noticing this is changed (fixed) in #1173 too. @stephenswat @CarloVarni what do you prefer we do here? |
|
That would only fix the issue for Carlo's new callable-based implementation of these functions, right? |
|
IIUC the PR also contains this fix. |
|
Oh so it does, let's go with Carlo's pull request then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've discovered that #1143 introduces a subtle but rather nefarious bug in the seed finder utilities: the
constqualifier on one of the types was removed in the.ippfile, but not in the corresponding.hppfile. This means that any code importing the.hppwill gladly compile the code, but because a matching implementation is not present in the.ippfile, it will rely on this implementation being made available at link time. In this particular case, that never happens, and we run into rather hard to debug linking errors. This commit resolves the issue by making sure that the function signatures between the.hppfile and the.ippfile are the same.