feat: cut to the maximum value of delta z between SPs in seedFinder #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuisFelipeCoelho
added
Component - Core
stephenswat
suggested changes
Mar 28, 2022
Codecov Report
@@ Coverage Diff @@
## main #1209 +/- ##
==========================================
- Coverage 47.92% 47.90% -0.02%
==========================================
Files 371 371
Lines 19388 19395 +7
Branches 9133 9135 +2
==========================================
Hits 9291 9291
- Misses 3766 3773 +7
Partials 6331 6331
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
robertlangenberg
approved these changes
Mar 29, 2022
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
stephenswat
approved these changes
Mar 29, 2022
|
I think the CI failure here is codecov complaining that coverage goes down too much (0.2%). Is there a reasonable way for you to add some additional test coverage @LuisFelipeCoelho ? Otherwise I can override this and merge manually. |
|
Not sure why the codecov check is still pending, let me manually merge this one then. |
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 18, 2022
same cut included in default seeding #1209
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Oct 20, 2022
same cut included in default seeding acts-project#1209
paulgessinger
pushed a commit
that referenced
this pull request
Oct 20, 2022
same cut included in default seeding #1209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a cut to the maximum value of delta z between SPs in seedFinder. By default the cut is not applied since
deltaZMaxis set tonumeric_limits<float>::max()This cut will be used for the strip SPs in the ITk implementation but not for the pixel SPs