feat: Add compatibility method to seedfinder #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenswat
added
Component - Core
In the past, the seedfinder could be called with three spacepoint ranges, one for the lower, one for the middle, and one for the top spacepoints. In recent times, the seedfinder has been optimized impressively, but this has meant making the function call for the seeder quite a bit more complex; it now requires an output iterator, a state, and an extent for radii. For compatibility and ease-of-use reasons, I think it would be nice to have an "old-style" interface. This commit adds that.
stephenswat
force-pushed
the
feat/seedfinder_compat
branch
from
a056127
to
9cf5766
Compare
Codecov Report
@@ Coverage Diff @@
## main #1198 +/- ##
=======================================
Coverage 47.75% 47.75%
=======================================
Files 360 360
Lines 18616 18616
Branches 8774 8774
=======================================
Hits 8890 8890
Misses 3674 3674
Partials 6052 6052
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
paulgessinger
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, the seedfinder could be called with three spacepoint ranges, one for the lower, one for the middle, and one for the top spacepoints. In recent times, the seedfinder has been optimized impressively, but this has meant making the function call for the seeder quite a bit more complex; it now requires an output iterator, a state, and an extent for radii. For compatibility and ease-of-use reasons, I think it would be nice to have an "old-style" interface. This commit adds that.