refactor!: Using non const InternalSpacePoint objects

[noemina]

This PR tries to fix usage of mutable properties in #1168 and #1143.

Tagging: @paulgessinger @robertlangenberg @LuisFelipeCoelho

BREAKING CHANGE: Remove assumption on constness of InternalSpacePoint.
The need of this major change is to allow seed finding and filtering to evaluate and set properties of InternalSpacePoints as soon as they are candidates for triplet formation and seed quality evaluation.

[codecov]

Codecov Report

Merging #1196 (26fcf40) into main (1674bce) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1196      +/-   ##
==========================================
- Coverage   47.81%   47.79%   -0.03%     
==========================================
  Files         360      360              
  Lines       18591    18600       +9     
  Branches     8769     8770       +1     
==========================================
  Hits         8890     8890              
- Misses       3649     3658       +9     
  Partials     6052     6052              

Impacted Files	Coverage Δ
Core/include/Acts/Seeding/BinnedSPGroup.hpp	0.00% <0.00%> (ø)
Core/include/Acts/Seeding/BinnedSPGroup.ipp	0.00% <0.00%> (ø)
Core/include/Acts/Seeding/InternalSeed.hpp	0.00% <ø> (ø)
Core/include/Acts/Seeding/InternalSpacePoint.hpp	0.00% <0.00%> (ø)
Core/include/Acts/Seeding/SeedFilter.hpp	0.00% <ø> (ø)
Core/include/Acts/Seeding/SeedFilter.ipp	0.00% <0.00%> (ø)
Core/include/Acts/Seeding/SeedFinderUtils.ipp	0.00% <0.00%> (ø)
Core/include/Acts/Seeding/Seedfinder.hpp	0.00% <ø> (ø)
Core/include/Acts/Seeding/SpacePointGrid.hpp	0.00% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[paulgessinger]

Looks good overall. I added a few comments.

I believe this breaks backward compatibility, and should be noted. Once we're ready to merge, can you write 2 sentences describing the change, that we can put into the release notes once this goes in?

[krasznaa]

@beomki-yeo, @konradkusiak97, could you help Noemi update the CUDA and SYCL seedfinder code in this PR? Unfortunately I think the changes will have to be made in this single PR, as she is changing some interfaces that all implementations of the seed-finding are using. (So we can't easily just patch the CUDA and SYCL codes first, before this change would be made.)

As far as I can see the changes necessary for the CUDA and SYCL plugins should be mostly trivial. (Re)moving some const statements here and there. But I thought you two should help out with that. 😉 (By either telling Noemi what she should do in those plugins to make them work with her updates, or by sending her patch files with the changes that you would propose.)

[konradkusiak97]

@beomki-yeo, @konradkusiak97, could you help Noemi update the CUDA and SYCL seedfinder code in this PR? Unfortunately I think the changes will have to be made in this single PR, as she is changing some interfaces that all implementations of the seed-finding are using. (So we can't easily just patch the CUDA and SYCL codes first, before this change would be made.)

As far as I can see the changes necessary for the CUDA and SYCL plugins should be mostly trivial. (Re)moving some const statements here and there. But I thought you two should help out with that. wink (By either telling Noemi what she should do in those plugins to make them work with her updates, or by sending her patch files with the changes that you would propose.)

Okay, I made the changes for CUDA and SYCL plugins.

[beomki-yeo]

Did you change all CUDA 1&2 plugins?

[konradkusiak97]

Did you change all CUDA 1&2 plugins?

Yes

[beomki-yeo]

Great Thanks!

[noemina]

I have committed the changes from @konradkusiak97. Thank you!

[paulgessinger]

Let's do this then.