feat: Allow setting ACTS_LOG_FAILURE_THRESHOLD at runtime #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The physics perf monitoring in acts-project#1193 runs on the ODD, which currently throws a number of ERRORs. To circumvent this, this PR allows setting the threshold through an environment variable, in addition to the compile time option.
HadrienG2
approved these changes
Mar 16, 2022
Codecov Report
@@ Coverage Diff @@
## main #1195 +/- ##
==========================================
- Coverage 47.85% 47.81% -0.04%
==========================================
Files 360 360
Lines 18568 18591 +23
Branches 8759 8769 +10
==========================================
+ Hits 8885 8890 +5
- Misses 3634 3649 +15
- Partials 6049 6052 +3
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The physics perf monitoring in #1193 runs on the ODD, which currently
throws a number of ERRORs. To circumvent this, this PR allows setting
the threshold through an environment variable, in addition to the
compile time option.