build: Allow python bindings to be used from install #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1194 +/- ##
=======================================
Coverage 47.81% 47.81%
=======================================
Files 360 360
Lines 18591 18591
Branches 8769 8769
=======================================
Hits 8890 8890
Misses 3649 3649
Partials 6052 6052 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
@stephenswat can you look at this maybe? Shouldn't be overly complex. |
stephenswat
approved these changes
Mar 18, 2022
|
Yes it is, this should not affect that. Main difference is that from a build, the python files should be symlinked (to allow changing them without rebuilding) whereas they are copied for an install. Let me actually double check that though, just to be safe. |
|
Still works on my end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some changes to enable the python bindings to be used from an install. Instead of
source $BUILD/python/setup.shyou can now dosource $INSTALL/python/setup.sh.The folder
pythonwon't make sense if ACTS is installed into a directory alongside other projects, but I would argue in that case you would not want to enable the python bindings anyway.