fix: Assertion failure in propagation example #1180
Merged
+6
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was for some reason using matrix access with two arguments to set elements of a vector (the diagonal of a matrix). Switched to use single commponent element access.
paulgessinger
changed the title
stephenswat
approved these changes
Mar 2, 2022
stephenswat
added
automerge
Bug
Codecov Report
@@ Coverage Diff @@
## main #1180 +/- ##
=======================================
Coverage 47.83% 47.83%
=======================================
Files 360 360
Lines 18530 18530
Branches 8739 8739
=======================================
Hits 8863 8863
Misses 3631 3631
Partials 6036 6036 Continue to review full report at Codecov.
|
kodiakhq bot
pushed a commit
that referenced
this pull request
Mar 3, 2022
In the CI, we currently run the examples in Release only, which adds the `-DNDEBUG` flag and consequently disables `assert`. We can't run these in the CI with Debug, since that implies `-O0` and runs forever.
This PR adds a new CMake option `ACTS_FORCE_ASSERTIONS` which defaults to `OFF`. If enabled, this will prepend a system include directory `cmake/assert_include` to all compilation units, which contains a wrapper around `cassert`, `Eigen/{Core,Dense,Geometry}` which enables `assert` (and `eigen_assert`) regardless of `NDEBUG`.
I verified that this would have triggered the assertion from #1180 for example.
The CI jobs are configured to run with `ACTS_FORCE_ASSERTIONS=ON`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was for some reason using matrix access with two arguments to set elements of a vector (the diagonal of a matrix). Switched to use single component element access.