build: Remove bundled dependencies in favor of CMake FetchContent #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1177 +/- ##
=======================================
Coverage 47.77% 47.77%
=======================================
Files 360 360
Lines 18608 18608
Branches 8770 8770
=======================================
Hits 8890 8890
Misses 3666 3666
Partials 6052 6052 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
@krasznaa maybe you could have a look at this? |
|
Files of relevance should be
Everything else is deleted files. You should be able to click on "File filter" to hide deleted files:
|
|
@niermann999 could you review this maybe? |
asalzburger
approved these changes
Mar 21, 2022
asalzburger
added
Infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the past and also already implemented for vecmem, this PR removes the bundled copies of
and uses CMake's FetchContent to grab a copy. Also added is an option
ACTS_USE_SYSTEM_PYBIND11to allow using an already installed copy. For nlohmann_json and autodiff this was already present, and I don't think it's necessary for dfelibs.