Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove rMinMiddleSP and rMaxMiddleSP in the SeedFinder config #1175

Merged

Conversation

LuisFelipeCoelho
Copy link
Member

rMinMiddleSP and rMaxMiddleSP do not need to be configured in the SeedFinder config, so this PR removes them

@LuisFelipeCoelho LuisFelipeCoelho added this to the next milestone Mar 1, 2022
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #1175 (4349698) into main (c0aea9f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1175   +/-   ##
=======================================
  Coverage   47.84%   47.84%           
=======================================
  Files         360      360           
  Lines       18525    18525           
  Branches     8739     8739           
=======================================
  Hits         8863     8863           
  Misses       3626     3626           
  Partials     6036     6036           
Impacted Files Coverage Δ
Core/include/Acts/Seeding/SeedfinderConfig.hpp 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0aea9f...4349698. Read the comment docs.

@paulgessinger
Copy link
Member

For some reason policybot considers my approval ineligible...

@kodiakhq kodiakhq bot merged commit 11f59e3 into acts-project:main Mar 1, 2022
@LuisFelipeCoelho LuisFelipeCoelho deleted the seeding-r(Min,Max)MiddleSP branch March 2, 2022 09:30
@paulgessinger paulgessinger modified the milestones: next, v18.0.0 Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants