feat: Improvements to Cuboid Volume Builder #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds a way to provide an envelope in x separate from the surface thickness. This is needed for multi-sensor layers. The auto volume binning should now also take the envelope into account when calculating the binning.
fix: Passing the created protoLayer to the planeLayer factory
Fixed initialization issue in centroid estimation for multiple surface layer
Added explicit sort of the volumes vector by their center X location
|
Thanks @pbutti! I set the milestone and the CI should run now. |
|
I'll fix the build errors. |
Codecov Report
@@ Coverage Diff @@
## main #1166 +/- ##
==========================================
- Coverage 47.83% 47.80% -0.03%
==========================================
Files 360 360
Lines 18530 18549 +19
Branches 8739 8756 +17
==========================================
+ Hits 8863 8867 +4
- Misses 3631 3633 +2
- Partials 6036 6049 +13
Continue to review full report at Codecov.
|
niermann999
suggested changes
Feb 21, 2022
|
Opened a PR to the base branch in Paul's fork. When that is merged, the commits will be picked up. |
Removed redundant include. Added comment on the buildLayer method
niermann999
approved these changes
Mar 2, 2022
paulgessinger
added
automerge
Component - Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a number of changes to the CuboidVolumeBuilder to make it more robust.