fix: Delete assignment operator for internal SPs #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The internal spacepoint class promises that it has an assignment operator, but this is never implemented. This means that if you are to write some code that would invoke the assignment operator, you'll run into esoteric linker errors. We cannot usefully implement an assignment operator for this class, because it has a reference member. As such, we simply delete this operator.
stephenswat
added
Bug
Codecov Report
@@ Coverage Diff @@
## main #1160 +/- ##
=======================================
Coverage 47.90% 47.90%
=======================================
Files 359 359
Lines 18491 18491
Branches 8723 8723
=======================================
Hits 8859 8859
Misses 3603 3603
Partials 6029 6029
Continue to review full report at Codecov.
|
paulgessinger
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal spacepoint class promises that it has an assignment operator, but this is never implemented. This means that if you are to write some code that would invoke the assignment operator, you'll run into esoteric linker errors. We cannot usefully implement an assignment operator for this class, because it has a reference member. As such, we simply delete this operator.