Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement iterator support for k-d trees #1158

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

stephenswat
Copy link
Member

Since the elements in our k-d tree implementation are stored consecutively in memory, it is trivial (and performant) to provide iterator-based access to them, such that it becomes easier to loop over the elements of the tree in a flat fashion. Of course, the order of the elements will be somewhat unpredictable.

Since the elements in our k-d tree implementation are stored
consecutively in memory, it is trivial (and performant) to provide
iterator-based access to them, such that it becomes easier to loop over
the elements of the tree in a flat fashion. Of course, the order of the
elements will be somewhat unpredictable.
@stephenswat stephenswat added this to the next milestone Feb 13, 2022
@stephenswat stephenswat added Component - Core Affects the Core module Impact - Minor Nuissance bug and/or affects only a single module Improvement Changes to an existing feature labels Feb 14, 2022
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #1158 (fbc2536) into main (78c8f4a) will not change coverage.
The diff coverage is n/a.

❗ Current head fbc2536 differs from pull request most recent head 4ae157e. Consider uploading reports for the commit 4ae157e to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1158   +/-   ##
=======================================
  Coverage   47.90%   47.90%           
=======================================
  Files         359      359           
  Lines       18491    18491           
  Branches     8723     8723           
=======================================
  Hits         8859     8859           
  Misses       3603     3603           
  Partials     6029     6029           
Impacted Files Coverage Δ
Core/include/Acts/Utilities/KDTree.hpp 56.30% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78c8f4a...4ae157e. Read the comment docs.

Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@kodiakhq kodiakhq bot merged commit 20d23f1 into acts-project:main Feb 14, 2022
@paulgessinger paulgessinger modified the milestones: next, v17.1.0 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Component - Core Affects the Core module Impact - Minor Nuissance bug and/or affects only a single module Improvement Changes to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants