Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ATLAS beampipe radius in itk.py #1157

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

timadye
Copy link
Contributor

@timadye timadye commented Feb 10, 2022

Fixes #1144 for ATLAS geometry created by itk.py's buildITkGeometry.

@paulgessinger paulgessinger added this to the next milestone Feb 10, 2022
@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #1157 (d37001b) into main (5220f82) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1157   +/-   ##
=======================================
  Coverage   47.90%   47.90%           
=======================================
  Files         359      359           
  Lines       18491    18491           
  Branches     8723     8723           
=======================================
  Hits         8859     8859           
  Misses       3603     3603           
  Partials     6029     6029           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5220f82...d37001b. Read the comment docs.

@kodiakhq kodiakhq bot merged commit 78c8f4a into acts-project:main Feb 10, 2022
@paulgessinger paulgessinger modified the milestones: next, v17.1.0 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlapping volumes exception for ITk geometry
2 participants