-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce Exa.TrkX plugin #1151
Conversation
@paulgessinger Now where the first attempt to get the GPU CI running failed, should we merge this in and add the runtime-test later, or should we still wait? |
Yes, let's do that. No point in dragging this out longer for now. |
Once we merged this version, we can improve the runtime tests. We have implemented a new C++ version of the pipeline which should give us correct GNN results. It would be nice to merge those changes now and we will improve the implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm fine with the shape this PR is in now.
This PR introduces the Exa.TrkX plugin which implements the Exa.TrkX GNN-based track finding alongside with some examples.
I have already added a section to the CI-workflow-description, which won't work until the required docker image has been merged to the machines-repository (see acts-project/machines#43)
Points which may need some discussion are