Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce Exa.TrkX plugin #1151

Merged
merged 103 commits into from
Mar 28, 2022
Merged

Conversation

benjaminhuth
Copy link
Member

This PR introduces the Exa.TrkX plugin which implements the Exa.TrkX GNN-based track finding alongside with some examples.

I have already added a section to the CI-workflow-description, which won't work until the required docker image has been merged to the machines-repository (see acts-project/machines#43)

Points which may need some discussion are

  • the cmake configuration for CUDA, which I moved to a macro since it is now needed for two plugins.
  • wether we want to put ONNX model files into the repository (at the moment there are no working ones due to a bug in ONNX I think)

@benjaminhuth
Copy link
Member Author

@paulgessinger Now where the first attempt to get the GPU CI running failed, should we merge this in and add the runtime-test later, or should we still wait?

@paulgessinger
Copy link
Member

Yes, let's do that. No point in dragging this out longer for now.

@benjaminhuth benjaminhuth removed the 🚧 WIP Work-in-progress label Mar 23, 2022
@xju2
Copy link
Contributor

xju2 commented Mar 23, 2022

@paulgessinger Now where the first attempt to get the GPU CI running failed, should we merge this in and add the runtime-test later, or should we still wait?

Once we merged this version, we can improve the runtime tests. We have implemented a new C++ version of the pipeline which should give us correct GNN results. It would be nice to merge those changes now and we will improve the implementation.

@paulgessinger paulgessinger self-assigned this Mar 24, 2022
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm fine with the shape this PR is in now.

@kodiakhq kodiakhq bot merged commit 23677b7 into acts-project:main Mar 28, 2022
@benjaminhuth benjaminhuth deleted the plugin/exatrkx branch March 28, 2022 07:12
@paulgessinger paulgessinger modified the milestones: WIP, v18.0.0 Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants