feat: configurable particle gun #1093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalzburger
added
Improvement
Comment on lines
+41
to
+42
| particleConfig: list | ||
| partilce configuration: number of particles, particle type, charge flip |
There was a problem hiding this comment.
Argubaly this could be separate arguments, like numParticles, particlePdg and particleCargeFlip or something.
Codecov Report
@@ Coverage Diff @@
## main #1093 +/- ##
=======================================
Coverage 48.61% 48.61%
=======================================
Files 341 341
Lines 17499 17499
Branches 8261 8261
=======================================
Hits 8508 8508
Misses 3218 3218
Partials 5773 5773 Continue to review full report at Codecov.
|
|
Thanks, @asalzburger! I'll give it a go. |
asalzburger
commented
Dec 6, 2021
| def runParticleGun( | ||
| outputDirCsv = None, | ||
| outputDirRoot = None, | ||
| pConfig = [1 * u.GeV, 10 * u.GeV, True], |
There was a problem hiding this comment.
Better named momentumConfig
There was a problem hiding this comment.
Reviewing your own code? 😄
|
Changes will be incorporated into other PR |
timadye
pushed a commit
to timadye/acts
that referenced
this pull request
Dec 23, 2021
timadye
pushed a commit
to timadye/acts
that referenced
this pull request
Dec 23, 2021
timadye
pushed a commit
to timadye/acts
that referenced
this pull request
Feb 3, 2022
robertlangenberg
added a commit
that referenced
this pull request
Feb 8, 2022
* configurable particle gun * Python particle_gun and fatras examples can now be chained * `addParticleGun` and `addFatras` adds the required modules to the `Sequence`. * `runParticleGun` and `runFatras` rewritten to use `add*` to reproduce exactly the previous behaviour. * `ROOT_HASH_CHECKS=on pytest` run as before without change. * Optionally `runParticleGun` and `runFatras` can now accept `outputDir` as `pathlib.Path` or `str` (like `add*`) * Other Python examples not yet changed. Let's see how this one goes down. * rename `pConfig`->`momentumConfig` as per Andi's comment in #1093 * use Path where possible (#1128 (comment)) * use `namedtuple` to pass particle gun parameters * Keep ParametricParticleGenerator defaults if not specified by caller. Rely on defaults in examples. * allow `addParticleGun(MomentumConfig())` etc to be specified without keyword Co-authored-by: Andreas Salzburger <[email protected]> Co-authored-by: Tim Adye <[email protected]> Co-authored-by: robertlangenberg <[email protected]>
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Apr 11, 2022
Update the Python in `Examples/Scripts/Python` to allow configuration of various full-chain examples. Continuing the work of acts-project#1098 in order to complete the proposal originally discussed in acts-project#1093.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first attempt of updating the python scripts to be more flexible if needed.
Also tagging: @timadye