-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement: allow CKF to keep stopped branch #2967
Labels
Comments
This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs. |
this is handled with #3102 |
kodiakhq bot
pushed a commit
that referenced
this issue
May 3, 2024
…3102) Changes the CKF branch stopper to allow keeping the tracks after the branch is stopped. This is useful if a track already collected enough measurements but then starts to accumulate holes. This change should allow us to stop branches more aggressively because we don't have to be worried anymore to throw out valid track candidates. closes - #2967 blocked by - #3164 - #3163
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this issue
May 6, 2024
…cts-project#3102) Changes the CKF branch stopper to allow keeping the tracks after the branch is stopped. This is useful if a track already collected enough measurements but then starts to accumulate holes. This change should allow us to stop branches more aggressively because we don't have to be worried anymore to throw out valid track candidates. closes - acts-project#2967 blocked by - acts-project#3164 - acts-project#3163
This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs. |
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this issue
May 21, 2024
…cts-project#3102) Changes the CKF branch stopper to allow keeping the tracks after the branch is stopped. This is useful if a track already collected enough measurements but then starts to accumulate holes. This change should allow us to stop branches more aggressively because we don't have to be worried anymore to throw out valid track candidates. closes - acts-project#2967 blocked by - acts-project#3164 - acts-project#3163
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Following on from #2905, @andiwand suggested:
Maybe instead of the CKF's
BranchStopper
returning abool
, it could return an:Although the
enum
andbool
values are upwardly compatible, the type is obviously different, so I guess this would require a breaking change.If we are already changing the API, it might be useful to simplify the call signature to pass the track state by
const &
:This proposal is not urgent, so it could be included with the next breaking release.
The text was updated successfully, but these errors were encountered: