Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: allow CKF to keep stopped branch #2967

Closed
timadye opened this issue Feb 19, 2024 · 4 comments
Closed

Improvement: allow CKF to keep stopped branch #2967

timadye opened this issue Feb 19, 2024 · 4 comments
Labels
Improvement Changes to an existing feature Stale

Comments

@timadye
Copy link
Contributor

timadye commented Feb 19, 2024

Following on from #2905, @andiwand suggested:

Maybe the branch stopper can also return if the track should be kept or not? I could imagine that we could use both scenarios: early removal of uninteresting tracks and stopping the propagation to save CPU and keeping the tracks.

Maybe instead of the CKF's BranchStopper returning a bool, it could return an:

enum BranchStopperResult {
  ContinueBranch = 0,
  DiscardBranch = 1,
  StopAndKeepBranch = 2
};

Although the enum and bool values are upwardly compatible, the type is obviously different, so I guess this would require a breaking change.

If we are already changing the API, it might be useful to simplify the call signature to pass the track state by const &:

  using BranchStopper = Delegate<TrackStateFlag(const CombinatorialKalmanFilterTipState&,
                                      const typename traj_t::TrackStateProxy&)>;

This proposal is not urgent, so it could be included with the next breaking release.

Copy link

This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs.

@github-actions github-actions bot added the Stale label Mar 20, 2024
@AJPfleger AJPfleger added the Improvement Changes to an existing feature label Apr 17, 2024
@AJPfleger
Copy link
Contributor

@andiwand @timadye what is the status on this?

@andiwand
Copy link
Contributor

this is handled with #3102

@github-actions github-actions bot removed the Stale label Apr 17, 2024
kodiakhq bot pushed a commit that referenced this issue May 3, 2024
…3102)

Changes the CKF branch stopper to allow keeping the tracks after the branch is stopped. This is useful if a track already collected enough measurements but then starts to accumulate holes.

This change should allow us to stop branches more aggressively because we don't have to be worried anymore to throw out valid track candidates.

closes
- #2967

blocked by
- #3164
- #3163
EleniXoch pushed a commit to EleniXoch/acts that referenced this issue May 6, 2024
…cts-project#3102)

Changes the CKF branch stopper to allow keeping the tracks after the branch is stopped. This is useful if a track already collected enough measurements but then starts to accumulate holes.

This change should allow us to stop branches more aggressively because we don't have to be worried anymore to throw out valid track candidates.

closes
- acts-project#2967

blocked by
- acts-project#3164
- acts-project#3163
Copy link

This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs.

@github-actions github-actions bot added the Stale label May 17, 2024
asalzburger pushed a commit to asalzburger/acts that referenced this issue May 21, 2024
…cts-project#3102)

Changes the CKF branch stopper to allow keeping the tracks after the branch is stopped. This is useful if a track already collected enough measurements but then starts to accumulate holes.

This change should allow us to stop branches more aggressively because we don't have to be worried anymore to throw out valid track candidates.

closes
- acts-project#2967

blocked by
- acts-project#3164
- acts-project#3163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Changes to an existing feature Stale
Projects
None yet
Development

No branches or pull requests

3 participants