fix: Update RootTrajectorySummaryWriter.cpp - writing the correct vec…

…tor to branch (outlierChi2) (#2488) Fix: writing the correct vector to branch: outlierChi2 instead of measurementChi2. Reopened #2363 so I can update the references. --------- Co-authored-by: altsybee <[email protected]>
acts-project · Oct 10, 2023 · ea7aaa5 · ea7aaa5
1 parent 658faae
commit ea7aaa5
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 13 deletions.
diff --git a/CI/physmon/reference/tracksummary_ckf_orthogonal_hist.root b/CI/physmon/reference/tracksummary_ckf_orthogonal_hist.root
diff --git a/CI/physmon/reference/tracksummary_ckf_seeded_hist.root b/CI/physmon/reference/tracksummary_ckf_seeded_hist.root
diff --git a/CI/physmon/reference/tracksummary_ckf_truth_estimated_hist.root b/CI/physmon/reference/tracksummary_ckf_truth_estimated_hist.root
diff --git a/CI/physmon/reference/tracksummary_ckf_truth_smeared_hist.root b/CI/physmon/reference/tracksummary_ckf_truth_smeared_hist.root
diff --git a/CI/physmon/reference/tracksummary_ckf_ttbar_hist.root b/CI/physmon/reference/tracksummary_ckf_ttbar_hist.root
diff --git a/Examples/Io/Root/src/RootTrajectorySummaryWriter.cpp b/Examples/Io/Root/src/RootTrajectorySummaryWriter.cpp
@@ -255,7 +255,7 @@ ActsExamples::ProcessCode ActsExamples::RootTrajectorySummaryWriter::writeT(
       m_chi2Sum.push_back(trajState.chi2Sum);
       m_NDF.push_back(trajState.NDF);
       m_measurementChi2.push_back(trajState.measurementChi2);
-      m_outlierChi2.push_back(trajState.measurementChi2);
+      m_outlierChi2.push_back(trajState.outlierChi2);
       // They are stored as double (as the vector of vector of int is not known
       // to ROOT)
       m_measurementVolume.emplace_back(trajState.measurementVolume.begin(),

diff --git a/Examples/Python/tests/root_file_hashes.txt b/Examples/Python/tests/root_file_hashes.txt
@@ -23,21 +23,21 @@ test_itk_seeding__particles_initial.root: 88315e93ed4cb5d40a8721502048a9d1fc100e
 test_propagation__propagation_steps.root: 174301b25784dbb881196b658f2d7f99c0a2ea688a0129e6110fc19aa5cf8e54
 test_material_recording__geant4_material_tracks.root: e411152d370775463c22b19a351dfc7bfe40b51985e10a7c1a010aebde80715d
 test_truth_tracking_kalman[generic-0.0]__trackstates_fitter.root: 0cdfeb13eaff45df38451820fcc15a7dfb40e55dab220e6e1d4d6f027ee8d4c8
-test_truth_tracking_kalman[generic-0.0]__tracksummary_fitter.root: b0d5d7ee2e742aef97db99ed34dce0024cfa947a60f57b16c2e4033c48656cf7
+test_truth_tracking_kalman[generic-0.0]__tracksummary_fitter.root: 1b76bad8f1e7cbaeaa2bc4f6d866a3b4289fc39947d950ab0c2efbeae77427e0
 test_truth_tracking_kalman[generic-0.0]__performance_track_finder.root: ada9cda2ec3c648b144bdaa081d6eff923c80f3d484c4196006e847428cf67a8
 test_truth_tracking_kalman[generic-1000.0]__trackstates_fitter.root: 5d54954ad21b8153b1788ccc296680a50969c761924f1c5db0600033d4577a3c
-test_truth_tracking_kalman[generic-1000.0]__tracksummary_fitter.root: 3ecd6851e1633103b9ae20140aa8f6a5a27aecc777177cd83078ed292544d9ae
+test_truth_tracking_kalman[generic-1000.0]__tracksummary_fitter.root: d809641c9414dac7284101c72a0cfd514699ec2b95468fd8640241ad4d32d8ad
 test_truth_tracking_kalman[generic-1000.0]__performance_track_finder.root: ada9cda2ec3c648b144bdaa081d6eff923c80f3d484c4196006e847428cf67a8
 test_truth_tracking_kalman[odd-0.0]__trackstates_fitter.root: f56a0ff4bb33412e4922804688ca6e8957f2b226730deb6b8425d7630557cc29
-test_truth_tracking_kalman[odd-0.0]__tracksummary_fitter.root: ad658cbc40170585f415cd1558ad0665b692556deb298e84c5372b0ccab03633
+test_truth_tracking_kalman[odd-0.0]__tracksummary_fitter.root: cdf06f936f5a59d74f3a44f147e30c10bc12f43a73180acfda871e53e77d9d50
 test_truth_tracking_kalman[odd-0.0]__performance_track_finder.root: 39aec6316cceb90e314e16b02947faa691c18f57c3a851a25e547a8fc05a4593
 test_truth_tracking_kalman[odd-1000.0]__trackstates_fitter.root: 97d89826902501803191f17c6a678181448d546276497fef946f33911b181bfc
-test_truth_tracking_kalman[odd-1000.0]__tracksummary_fitter.root: 8d6f97c16875f638fe82d2c5524cc9b674a7e2d190f9ba705a7c2e4996e768d6
+test_truth_tracking_kalman[odd-1000.0]__tracksummary_fitter.root: f434d1784a5621af80bb0a4bdf194f1ce8a0581b95e1abe79c0e55d7d37d85cb
 test_truth_tracking_kalman[odd-1000.0]__performance_track_finder.root: 39aec6316cceb90e314e16b02947faa691c18f57c3a851a25e547a8fc05a4593
 test_truth_tracking_gsf[generic]__trackstates_gsf.root: 8d09c4c31bf65866645b779ceb764b2efabe82c64e2bdc84d77e343a8249ca4d
-test_truth_tracking_gsf[generic]__tracksummary_gsf.root: 91a6451e0fc87434cd60422127a8cd8d6ac01cd5390c75b24c446cbf2ff42e4c
+test_truth_tracking_gsf[generic]__tracksummary_gsf.root: 01f5a6e169642dc54307526c9921c6d5b9fd6e694e935df42ef8ed81a67babe2
 test_truth_tracking_gsf[odd]__trackstates_gsf.root: a2364a5072145c7eb4ecf8c67b2e48c8c528fe5ab9307d078c9e5f1f659d87e0
-test_truth_tracking_gsf[odd]__tracksummary_gsf.root: f3c47456c36dd44cb0c8e0371e8e5d8c5e2ba17a8c633e845f5d28a25db3aa0c
+test_truth_tracking_gsf[odd]__tracksummary_gsf.root: 6cb9802b3afa85d41261a77da4ea20754fdcd54f86e682ec864764b1475994ed
 test_particle_gun__particles.root: 8549ba6e20338004ab8ba299fc65e1ee5071985b46df8f77f887cb6fef56a8ec
 test_material_mapping__material-map_tracks.root: 2deac7a48ff1185ba3889cfd4cc0bd0a6de57293048dfd6766f3c3907232e45e
 test_material_mapping__propagation-material.root: 84b04ebd5721550867f0f193b5eb4e9f3f205df542cb46090d320be6bff565c5
@@ -50,21 +50,21 @@ test_digitization_example_input[smeared]__measurements.root: dd6d1af353a676d28ac
 test_digitization_example_input[geometric]__particles.root: 8549ba6e20338004ab8ba299fc65e1ee5071985b46df8f77f887cb6fef56a8ec
 test_digitization_example_input[geometric]__measurements.root: 56a64b3df65fcd04d677fac6b6ee3f1978fe6d7777599bb918d40e514ef45a1f
 test_ckf_tracks_example[generic-full_seeding]__trackstates_ckf.root: 1786b1f1e90a8fe2ad6f534072506bacf8dbcf1a7e25c283a5ab261a319479fb
-test_ckf_tracks_example[generic-full_seeding]__tracksummary_ckf.root: 359be063e44247439490d4ae99fa3c9c240e8c0777b27421b26b63f62c85e2f0
+test_ckf_tracks_example[generic-full_seeding]__tracksummary_ckf.root: 7d0fd1fa4c9057c7cce7d1acc06e18b0c2a35a047d0b23d646c7cd5d73bb8fe5
 test_ckf_tracks_example[generic-full_seeding]__performance_seeding_trees.root: 0e0676ffafdb27112fbda50d1cf627859fa745760f98073261dcf6db3f2f991e
 test_ckf_tracks_example[generic-truth_estimated]__trackstates_ckf.root: 7dd654c2223f3c53eac4ba496b3dec3739d29a443e9a77e718981bad44b95f1c
-test_ckf_tracks_example[generic-truth_estimated]__tracksummary_ckf.root: 49b39633c0794f7c215b07626dcaba026e4358a795198b29fb0b59fde41abff4
+test_ckf_tracks_example[generic-truth_estimated]__tracksummary_ckf.root: 6ab977c6061e75960217e7376bd459766981bbefd0b63f58d4f73db7c8cf4b3f
 test_ckf_tracks_example[generic-truth_estimated]__performance_seeding.root: 1facb05c066221f6361b61f015cdf0918e94d9f3fce2269ec7b6a4dffeb2bc7e
 test_ckf_tracks_example[generic-truth_smeared]__trackstates_ckf.root: 0351e6e87bbda82c666e3580f8437fa9736f9d95ec4dd8658129bc73bb3fbf6c
-test_ckf_tracks_example[generic-truth_smeared]__tracksummary_ckf.root: d0d843bdb92b39dea1151894f411d645ccaae2423f9293e3251d082835b126bb
+test_ckf_tracks_example[generic-truth_smeared]__tracksummary_ckf.root: cc69920c2a6b571baa680bd12a605e7b2f9d59afec7dcfc82565c4951f831ef6
 test_ckf_tracks_example[odd-full_seeding]__trackstates_ckf.root: 6a7630f6845bc5cfca18741fa1347244f35aed499a2585ac3d7e4f4cb31c87d5
-test_ckf_tracks_example[odd-full_seeding]__tracksummary_ckf.root: 4fdcdb6122f88b8710f75bf99a7d09d7e265a3964f10875fa7b3970ddef179e0
+test_ckf_tracks_example[odd-full_seeding]__tracksummary_ckf.root: 38d4f157f342447c149be4a15450b4455757cc0ff23316c68c9a92bb16356508
 test_ckf_tracks_example[odd-full_seeding]__performance_seeding_trees.root: 43c58577aafe07645e5660c4f43904efadf91d8cda45c5c04c248bbe0f59814f
 test_ckf_tracks_example[odd-truth_estimated]__trackstates_ckf.root: ffe11d3dbcc89ad78f96487167beafc36355e8359140883fa4f6f08b256e5e77
-test_ckf_tracks_example[odd-truth_estimated]__tracksummary_ckf.root: f7ab145a061873065dc3bbfc7d56a779729afbe1c2a4083beaef35b4058f4afa
+test_ckf_tracks_example[odd-truth_estimated]__tracksummary_ckf.root: 910af253f44bc53630912688f71868b5d707aad0351071b8f63552d294a75e3a
 test_ckf_tracks_example[odd-truth_estimated]__performance_seeding.root: 1a36b7017e59f1c08602ef3c2cb0483c51df248f112e3780c66594110719c575
 test_ckf_tracks_example[odd-truth_smeared]__trackstates_ckf.root: 11e26017fa19a3ba6e5cd87be2810725764555736613306ce9fb044d6acfaef7
-test_ckf_tracks_example[odd-truth_smeared]__tracksummary_ckf.root: 7cb34ce6f29e2d84d7bf61c00be37aed721179c0d032453e0188f6277fdc3a1b
+test_ckf_tracks_example[odd-truth_smeared]__tracksummary_ckf.root: 28d3200bea541eda197a2310991c7481c198787e94c4796ddd0aca9a5b6a7d24
 test_vertex_fitting_reading[Truth-False-100]__performance_vertexing.root: 76ef6084d758dfdfc0151ddec2170e12d73394424e3dac4ffe46f0f339ec8293
 test_vertex_fitting_reading[Iterative-False-100]__performance_vertexing.root: 60372210c830a04f95ceb78c6c68a9b0de217746ff59e8e73053750c837b57eb
 test_vertex_fitting_reading[Iterative-True-100]__performance_vertexing.root: e34f217d524a5051dbb04a811d3407df3ebe2cc4bb7f54f6bda0847dbd7b52c3