fix: TrackSelector eta vs theta (#1615)

`theta != eta`
acts-project · Oct 24, 2022 · b518cb2 · b518cb2
1 parent 4b9d9c4
commit b518cb2
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 3 deletions.
diff --git a/CI/physmon/reference/performance_vertexing_seeded_hist.root b/CI/physmon/reference/performance_vertexing_seeded_hist.root
diff --git a/CI/physmon/reference/performance_vertexing_truth_estimated_hist.root b/CI/physmon/reference/performance_vertexing_truth_estimated_hist.root
diff --git a/CI/physmon/reference/performance_vertexing_truth_smeared_hist.root b/CI/physmon/reference/performance_vertexing_truth_smeared_hist.root
diff --git a/Examples/Algorithms/TruthTracking/ActsExamples/TruthTracking/TrackSelector.cpp b/Examples/Algorithms/TruthTracking/ActsExamples/TruthTracking/TrackSelector.cpp
@@ -45,7 +45,7 @@ ActsExamples::ProcessCode ActsExamples::TrackSelector::execute(
     const bool validCharge = validNeutral or validCharged;
     return validCharge and
            within(trk.transverseMomentum(), m_cfg.ptMin, m_cfg.ptMax) and
-           within(std::abs(theta), m_cfg.absEtaMin, m_cfg.absEtaMax) and
+           within(std::abs(eta), m_cfg.absEtaMin, m_cfg.absEtaMax) and
            within(eta, m_cfg.etaMin, m_cfg.etaMax) and
            within(trk.template get<Acts::eBoundPhi>(), m_cfg.phiMin,
                   m_cfg.phiMax) and

diff --git a/Examples/Python/tests/root_file_hashes.txt b/Examples/Python/tests/root_file_hashes.txt
@@ -86,9 +86,9 @@ test_digitization_example_input__particles.root: 78a89f365177423d0834ea6f1bd8afe
 
 test_vertex_fitting_reading[Truth-False-100]__performance_vertexing.root: 7d707c6adf9a9e84529a42485b727e64c40cd00c400df509bb05c3ceb766c69d
 test_vertex_fitting_reading[Iterative-False-100]__performance_vertexing.root: 972f15c54393891e1b504bfc57c2e03603015a30106882920b5e316347d6dd11
-test_vertex_fitting_reading[Iterative-True-100]__performance_vertexing.root: d9f61b58bb2e771760103b1e8679502b4f45b944a54ce5dc40690b51a185b5ad
+test_vertex_fitting_reading[Iterative-True-100]__performance_vertexing.root: 32d93fb327b2ad4f18d89586c4d5faed0b2555e7679a2f643ec6f01d428c9e0e
 test_vertex_fitting_reading[AMVF-False-100]__performance_vertexing.root: b081a3c8505ad0a1bf15a4f76e6befdbca8ec077de2d3034e2cd6eddafe4ee66
-test_vertex_fitting_reading[AMVF-True-100]__performance_vertexing.root: 5b5180a75dab6cc819f2c55dae989f30274b077ddcb238b0fced573c7fa94f21
+test_vertex_fitting_reading[AMVF-True-100]__performance_vertexing.root: 150d01d5bded858b1781f6b64bf4d577943ee6dcce88e3910a3c7bafb16a82a6
 
 test_bfield_writing__solenoid.root: 33a90bb1efd936a9899ea882d0d10240403d123749dbed70984e4d796be534df
 test_bfield_writing__solenoid2.root: dd0067444846f3e20098000f730dc4a4e2fc87551c8e2fb3d0a91725e03ab5a8