fix: Propagate initial vertex time variance for AMVF w/o time (#2936)

Logs like ``` 21:16:17 VertexPerfor WARNING Nonpositive variance after vertex fit: Var(T) = 0 <= 0. ``` are gone after this change. To me it seems more sensical to propagate the initial time variance instead of hard setting it to `0` which causes the cov matrix to be invalid.
acts-project · Feb 13, 2024 · b50dd08 · b50dd08
1 parent 86e62ab
commit b50dd08
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 2 deletions.
diff --git a/CI/physmon/reference/performance_amvf_gridseeder_ttbar_hist.root b/CI/physmon/reference/performance_amvf_gridseeder_ttbar_hist.root
diff --git a/CI/physmon/reference/performance_amvf_orthogonal_hist.root b/CI/physmon/reference/performance_amvf_orthogonal_hist.root
diff --git a/CI/physmon/reference/performance_amvf_seeded_hist.root b/CI/physmon/reference/performance_amvf_seeded_hist.root
diff --git a/CI/physmon/reference/performance_amvf_truth_estimated_hist.root b/CI/physmon/reference/performance_amvf_truth_estimated_hist.root
diff --git a/CI/physmon/reference/performance_amvf_truth_smeared_hist.root b/CI/physmon/reference/performance_amvf_truth_smeared_hist.root
diff --git a/CI/physmon/reference/performance_amvf_ttbar_hist.root b/CI/physmon/reference/performance_amvf_ttbar_hist.root
diff --git a/Core/src/Vertexing/KalmanVertexUpdater.cpp b/Core/src/Vertexing/KalmanVertexUpdater.cpp
@@ -167,9 +167,7 @@ void update(Vector4& vtxPos, SquareMatrix4& vtxCov,
 
   // Updating the vertex
   if constexpr (nDimVertex == 3) {
-    vtxPos.setZero();
     vtxPos.head<3>() = cache.newVertexPos.template head<3>();
-    vtxCov.setZero();
     vtxCov.template topLeftCorner<3, 3>() =
         cache.newVertexCov.template topLeftCorner<3, 3>();
   } else if constexpr (nDimVertex == 4) {