Skip to content

Commit

Permalink
refactor: Delete the examples binaries (#2685)
Browse files Browse the repository at this point in the history
This PR deletes the Examples binaries
  • Loading branch information
paulgessinger authored Feb 12, 2024
1 parent 1a4778a commit a5b3864
Show file tree
Hide file tree
Showing 202 changed files with 19 additions and 10,594 deletions.
9 changes: 0 additions & 9 deletions .github/workflows/builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ jobs:
-DACTS_BUILD_EVERYTHING=ON
-DACTS_BUILD_ODD=ON
-DACTS_BUILD_EXAMPLES_PYTHON_BINDINGS=ON
-DACTS_BUILD_EXAMPLES_BINARIES=ON
-DACTS_BUILD_EXAMPLES_EDM4HEP=ON
-DACTS_FORCE_ASSERTIONS=ON
-DACTS_BUILD_ANALYSIS_APPS=ON
Expand Down Expand Up @@ -139,13 +138,6 @@ jobs:
- name: Unpack build
run: mkdir build && tar xf build.tar.gz -C build

- name: Examples
shell: bash
run: >
export LD_LIBRARY_PATH=$PWD/build/thirdparty/OpenDataDetector/factory:$LD_LIBRARY_PATH
&& source /usr/local/bin/thisdd4hep_only.sh
&& ./CI/run_examples.sh
- name: Python level tests
shell: bash
env:
Expand Down Expand Up @@ -422,7 +414,6 @@ jobs:
-DCMAKE_CXX_FLAGS=-Werror
-DCMAKE_INSTALL_PREFIX="${INSTALL_DIR}"
-DACTS_LOG_FAILURE_THRESHOLD=WARNING
-DACTS_BUILD_EXAMPLES_BINARIES=ON
-DACTS_FORCE_ASSERTIONS=ON
-DACTS_USE_SYSTEM_BOOST=OFF
-DACTS_USE_SYSTEM_EIGEN3=OFF
Expand Down
132 changes: 0 additions & 132 deletions CI/run_examples.sh

This file was deleted.

9 changes: 4 additions & 5 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ option(ACTS_BUILD_EXAMPLES_GEANT4 "Build Geant4-based code in the examples" OFF)
option(ACTS_BUILD_EXAMPLES_HEPMC3 "Build HepMC3-based code in the examples" OFF)
option(ACTS_BUILD_EXAMPLES_PYTHIA8 "Build Pythia8-based code in the examples" OFF)
option(ACTS_BUILD_EXAMPLES_PYTHON_BINDINGS "Build python bindings for the examples" OFF)
option(ACTS_BUILD_EXAMPLES_BINARIES "Build the examples binaries (deprecated)" OFF)
option(ACTS_USE_SYSTEM_PYBIND11 "Use a system installation of pybind11" ${ACTS_USE_SYSTEM_LIBS} )
option(ACTS_USE_EXAMPLES_TBB "Use Threading Building Blocks library in the examples" ON)
option(ACTS_BUILD_ANALYSIS_APPS "Build Analysis applications in the examples" OFF)
Expand Down Expand Up @@ -131,7 +130,7 @@ set_option_if(
ACTS_BUILD_EVERYTHING)
set_option_if(
ACTS_BUILD_PLUGIN_GEANT4
ACTS_BUILD_EXAMPLES_GEANT4 OR ACTS_BUILD_EVERYTHING)
ACTS_BUILD_EXAMPLES_GEANT4 OR ACTS_BUILD_EVERYTHING)
set_option_if(
ACTS_BUILD_PLUGIN_TGEO
ACTS_BUILD_PLUGIN_DD4HEP OR ACTS_BUILD_EXAMPLES OR ACTS_BUILD_EVERYTHING)
Expand All @@ -146,7 +145,7 @@ set_option_if(
ACTS_BUILD_EXAMPLES OR ACTS_BUILD_EVERYTHING)
set_option_if(ACTS_BUILD_PLUGIN_LEGACY ACTS_BUILD_EVERYTHING)
set_option_if(ACTS_BUILD_PLUGIN_EXATRKX ACTS_BUILD_EXAMPLES_EXATRKX)
set_option_if(ACTS_BUILD_PLUGIN_FPEMON
set_option_if(ACTS_BUILD_PLUGIN_FPEMON
ACTS_BUILD_EXAMPLES OR ACTS_BUILD_EVERYTHING)

# feature tests
Expand Down Expand Up @@ -317,7 +316,7 @@ if(ACTS_BUILD_PLUGIN_EXATRKX)
message(WARNING "CUDA not found, build Exa.TrkX plugin only for CPU")
endif()
if(NOT (ACTS_EXATRKX_ENABLE_ONNX OR ACTS_EXATRKX_ENABLE_TORCH))
message(FATAL_ERROR
message(FATAL_ERROR
"When building the Exa.TrkX plugin, at least one of ACTS_EXATRKX_ENABLE_ONNX \
and ACTS_EXATRKX_ENABLE_TORCHSCRIPT must be enabled."
)
Expand Down Expand Up @@ -354,7 +353,7 @@ if(ACTS_BUILD_EXAMPLES)
endif()
if(ACTS_BUILD_EXAMPLES_PYTHON_BINDINGS)
find_package(Python 3.8 REQUIRED COMPONENTS Interpreter Development)
if(ACTS_USE_SYSTEM_PYBIND11)
if(ACTS_USE_SYSTEM_PYBIND11)
find_package(pybind11 CONFIG REQUIRED)
else()
add_subdirectory(thirdparty/pybind11)
Expand Down
3 changes: 2 additions & 1 deletion Examples/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ add_subdirectory(Algorithms)
add_subdirectory(Detectors)
add_subdirectory(Framework)
add_subdirectory(Io)
add_subdirectory_if(Run ACTS_BUILD_EXAMPLES_BINARIES)
add_subdirectory_if(Python ACTS_BUILD_EXAMPLES_PYTHON_BINDINGS)
add_subdirectory_if(Scripts ACTS_BUILD_ANALYSIS_APPS)

add_subdirectory(HelloWorld)
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ target_link_libraries(
ActsExampleHelloWorld
PRIVATE
ActsCore
ActsExamplesFramework ActsExamplesCommon)
ActsExamplesFramework)

install(
TARGETS ActsExampleHelloWorld
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

#include "ActsExamples/Framework/RandomNumbers.hpp"
#include "ActsExamples/Framework/Sequencer.hpp"
#include "ActsExamples/Options/CommonOptions.hpp"

#include <cstdlib>
#include <memory>
Expand All @@ -21,29 +20,19 @@
#include "HelloWhiteBoardAlgorithm.hpp"

int main(int argc, char* argv[]) {
// setup options
// every component should have an associated option setup function
// that should be called here.
auto opt = ActsExamples::Options::makeDefaultOptions();
ActsExamples::Options::addSequencerOptions(opt);
ActsExamples::Options::addRandomNumbersOptions(opt);
// parse options from command line flags
auto vm = ActsExamples::Options::parse(opt, argc, argv);
// an empty variables map indicates an error
if (vm.empty()) {
return EXIT_FAILURE;
}

// extract some common options
auto logLevel = ActsExamples::Options::readLogLevel(vm);
(void)argc;
(void)argv;
Acts::Logging::Level logLevel = Acts::Logging::INFO;

// setup basic tools shared among algorithms
auto rnd = std::make_shared<ActsExamples::RandomNumbers>(
ActsExamples::Options::readRandomNumbersConfig(vm));
ActsExamples::RandomNumbers::Config{});

// setup the sequencer first w/ config derived from options
ActsExamples::Sequencer sequencer(
ActsExamples::Options::readSequencerConfig(vm));
ActsExamples::Sequencer::Config seqCfg;
seqCfg.events = 10;
seqCfg.numThreads = -1;
ActsExamples::Sequencer sequencer(seqCfg);

// add HelloWorld algorithm that does nothing
sequencer.addAlgorithm(
Expand Down
20 changes: 0 additions & 20 deletions Examples/Run/Alignment/CMakeLists.txt

This file was deleted.

19 changes: 0 additions & 19 deletions Examples/Run/Alignment/Common/CMakeLists.txt

This file was deleted.

Loading

0 comments on commit a5b3864

Please sign in to comment.