Skip to content

Commit

Permalink
fix(gx2f): improved actor and navigation break (#2972)
Browse files Browse the repository at this point in the history
This improves the actor by
- aborting when the navigation finished
- only acting on `associatedDetectorElement`

## Previous Problem
The propagation fails on some geometries with
```
Gx2fPropagat   ERROR     Step failed with MagneticFieldError:1: Interpolation out of bounds was requested
```
  • Loading branch information
AJPfleger authored Feb 21, 2024
1 parent e9ab1f7 commit a42f23b
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions Core/include/Acts/TrackFitting/GlobalChiSquareFitter.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -393,15 +393,20 @@ class Gx2Fitter {
const Logger& /*logger*/) const {
assert(result.fittedStates && "No MultiTrajectory set");

if (state.navigation.navigationBreak) {
ACTS_INFO("Actor: finish: state.navigation.navigationBreak");
result.finished = true;
}

if (result.finished) {
return;
}

// Update:
// - Waiting for a current surface
auto surface = navigator.currentSurface(state.navigation);
// std::string direction = state.stepping.navDir.toString();
if (surface != nullptr) {
if (surface != nullptr &&
surface->associatedDetectorElement() != nullptr) {
++result.surfaceCount;
ACTS_VERBOSE("Surface " << surface->geometryId() << " detected.");

Expand Down

0 comments on commit a42f23b

Please sign in to comment.