Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
XiaocongAi committed Apr 24, 2022
1 parent fafdcef commit 505bb60
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ struct CorrectedFreeToBoundTransformer {
ActsScalar alpha = 0.1;
ActsScalar beta = 2;

// The maximum incident angle (i.e. mininum cos incident angle) cutoff for
// The maximum incident angle (i.e. minimum cos incident angle) cutoff for
// correction
ActsScalar cosIncidentAngleMinCutoff = 1e-5;

// The minimum incident angle (i.e. mininum cos incident angle) cutoff for
// The minimum incident angle (i.e. maximum cos incident angle) cutoff for
// correction cos(0.1) = 0.99500417
ActsScalar cosIncidentAngleMaxCutoff = 0.99500417;

Expand Down
8 changes: 4 additions & 4 deletions Core/src/EventData/CorrectedTransformationFreeToBound.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -80,16 +80,16 @@ Acts::detail::CorrectedFreeToBoundTransformer::operator()(
std::vector<std::pair<BoundVector, ActsScalar>> transformedBoundParams;

// 1. The nominal one
const auto& [params_, mweight_, cweight_] = sampledFreeParams[0];
const auto& [paramsNom, mweightNom, cweightNom] = sampledFreeParams[0];
// Transform the free to bound
auto nominalRes =
detail::transformFreeToBoundParameters(params_, surface, geoContext);
detail::transformFreeToBoundParameters(paramsNom, surface, geoContext);
if (not nominalRes.ok()) {
return std::nullopt;
}
auto nominalBound = nominalRes.value();
transformedBoundParams.push_back({nominalBound, cweight_});
bpMean = bpMean + mweight_ * nominalBound;
transformedBoundParams.push_back({nominalBound, cweightNom});
bpMean = bpMean + mweightNom * nominalBound;

// 2. Loop over the rest sample points of the free parameters to get the
// weighted bound parameters
Expand Down
2 changes: 1 addition & 1 deletion Examples/Scripts/Python/truth_tracking.py
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def runTruthTracking(
directNavigation=directNavigation,
multipleScattering=True,
energyLoss=True,
globalToLocalCorrection=False,
freeToBoundCorrection=False,
pickTrack=-1,
reverseFilteringMomThreshold=reverseFilteringMomThreshold,
trackingGeometry=trackingGeometry,
Expand Down

0 comments on commit 505bb60

Please sign in to comment.