Merge branch 'main' into minor-interactions-precalc-constant

acts-project · Aug 21, 2023 · 17bb728 · 17bb728
2 parents adf0d4d + a2ddfc9
commit 17bb728
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/Core/include/Acts/Vertexing/KalmanVertexTrackUpdater.ipp b/Core/include/Acts/Vertexing/KalmanVertexTrackUpdater.ipp
@@ -29,8 +29,9 @@ void Acts::KalmanVertexTrackUpdater::update(TrackAtVertex<input_track_t>& track,
   const ActsMatrix<5, 3> posJac = linTrack.positionJacobian.block<5, 3>(0, 0);
   const ActsMatrix<5, 3> momJac = linTrack.momentumJacobian.block<5, 3>(0, 0);
   const ActsVector<5> trkParams = linTrack.parametersAtPCA.head<5>();
+  // TODO we could use `linTrack.weightAtPCA` but only if we would use time
   const ActsSymMatrix<5> trkParamWeight =
-      linTrack.weightAtPCA.block<5, 5>(0, 0);
+      linTrack.covarianceAtPCA.block<5, 5>(0, 0).inverse();
 
   // Calculate S matrix
   ActsSymMatrix<3> sMat =

diff --git a/Core/include/Acts/Vertexing/KalmanVertexUpdater.ipp b/Core/include/Acts/Vertexing/KalmanVertexUpdater.ipp
@@ -71,8 +71,9 @@ void Acts::KalmanVertexUpdater::updatePosition(
       linTrack.momentumJacobian.block<5, 3>(0, 0);  // B_k in comments below
   const ActsVector<5> trkParams = linTrack.parametersAtPCA.head<5>();
   const ActsVector<5> constTerm = linTrack.constantTerm.head<5>();
+  // TODO we could use `linTrack.weightAtPCA` but only if we would use time
   const ActsSymMatrix<5> trkParamWeight =
-      linTrack.weightAtPCA.block<5, 5>(0, 0);
+      linTrack.covarianceAtPCA.block<5, 5>(0, 0).inverse();
 
   // Vertex to be updated
   const Vector3& oldVtxPos = vtx.position();
@@ -119,8 +120,9 @@ double Acts::KalmanVertexUpdater::detail::trackParametersChi2(
   const ActsMatrix<5, 3> momJac = linTrack.momentumJacobian.block<5, 3>(0, 0);
   const ActsVector<5> trkParams = linTrack.parametersAtPCA.head<5>();
   const ActsVector<5> constTerm = linTrack.constantTerm.head<5>();
+  // TODO we could use `linTrack.weightAtPCA` but only if we would use time
   const ActsSymMatrix<5> trkParamWeight =
-      linTrack.weightAtPCA.block<5, 5>(0, 0);
+      linTrack.covarianceAtPCA.block<5, 5>(0, 0).inverse();
 
   const ActsVector<5> jacVtx = posJac * matrixCache.newVertexPos;