Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typed view types for messages #1034

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Conversation

Neverlord
Copy link
Member

The typed message view types are a missing puzzle piece for reimplementing the matching based on type_id_list.

Copy link
Member

@josephnoir josephnoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these are public headers we might want to add some documentation? And the license in the header stats 2019 not 20. Not sure if you want to address that.

@Neverlord Neverlord merged commit 5ba326f into master Feb 3, 2020
@Neverlord Neverlord deleted the topic/typed-message-views branch February 3, 2020 13:12
@Neverlord
Copy link
Member Author

Since these are public headers we might want to add some documentation?

Yes, I'll add some more documentation in a followup.

And the license in the header stats 2019 not 20. Not sure if you want to address that.

The dates are all over the place TBH. I'm thinking of minimizing the header boilerplate altogether to only a link to the original repo plus license and add a COPYING file to the repo instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants