Proper class hierarchy for Dependency #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to be able to separate the base type from the type for our pkg dependencies, so renamed the latter to PkgDependency. Previously we got an error when downloading zig deps since in the fetch code we would check if it's a pkg dependency or zig dependency and then delete from the corresponding list of outstanding downloads, but an isinstance check on the pkg Dependency also matched the base type of ZigDependency, and so we would try to delete it from the wrong dict and get an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to be able to separate the base type from the type for our pkg dependencies, so renamed the latter to PkgDependency.
Previously we got an error when downloading zig deps since in the fetch code we would check if it's a pkg dependency or zig dependency and then delete from the corresponding list of outstanding downloads, but an isinstance check on the pkg Dependency also matched the base type of ZigDependency, and so we would try to delete it from the wrong dict and get an error.
Fixes #1975