Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added vendor path in gemspec #79

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Added vendor path in gemspec #79

merged 2 commits into from
Oct 26, 2023

Conversation

aashishpsaini
Copy link
Contributor

Adds missing vendor path in Gemspec

@pull-request-checklist-buddy
Copy link

pull-request-checklist-buddy bot commented Oct 26, 2023 •
edited by canderson-activatecare
Loading

Security Review (Not for PR Owner)

@pull-request-checklist-buddy
Copy link

pull-request-checklist-buddy bot commented Oct 26, 2023 •
edited by aashishpsaini
Loading

Developer/Requestor Review

  • The code follows the Activate Care development guidelines.
  • There are appropriate tests, preferring unit tests to system tests.
  • Performance related impacts have been considered.
  • Commit messages follow our conventions.
  • If there is a migration needed, I have performed a staging migration test and updated development.sql.

canderson-activatecare
canderson-activatecare previously approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@canderson-activatecare canderson-activatecare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM sorry we missed this

@canderson-activatecare canderson-activatecare changed the base branch from master to develop October 26, 2023 17:02
@canderson-activatecare canderson-activatecare dismissed their stale review October 26, 2023 17:02

The base branch was changed.

canderson-activatecare
canderson-activatecare approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@canderson-activatecare canderson-activatecare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

migrate target branch to develop

@canderson-activatecare canderson-activatecare merged commit b7c041d into develop Oct 26, 2023
3 checks passed
@canderson-activatecare canderson-activatecare deleted the feature/fix-path-loading-issue branch October 26, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canderson-activatecare canderson-activatecare canderson-activatecare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aashishpsaini @canderson-activatecare