Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multiple tours with some not run #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jjb
Copy link

@jjb jjb commented Mar 24, 2022

before this, if a tour was encountered where tourMayStart
was false, then subsequent tours were not attempted

now, all incomplete tours are looped through until the first
runable one is run

for...in is used because it is the most compatible

example tour that this fix accommodates:

non_admin_intro:
  steps:
    1:
      text: "Welcome User!"
      attachTo:
        element: "#non-admin-tour"

admin_intro:
  steps:
    1:
      text: "Welcome Admin!"
      attachTo:
        element: "#admin-tour"

before this, if a tour was encountered where tourMayStart
was false, then subsequent tours were not attempted

now, all incomplete tours are looped through until the first
runable one is run

for...in is used because it is the most compatible
@jjb
Copy link
Author

jjb commented Oct 23, 2024

@canderson180 @aashishpsaini wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant