Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Feature
PR Checklist
Overview
This tries to implement #414 . I implemented these changes on
Scope
temporarily to use existing tests and for smaller diff.The new behavior for scope is equivalent to registering component services individually. This allows the scope to fallthrough when no matching route is found (instead of calling default service). A typical use case would be:
Setting
Scope::default_service()
, would make it mimic the original behavior.As a side-effect, this will also make #2096 possible.
Open questions
This introduces new API. So I'm looking for input before finishing it. Specifically, I'm looking for the naming (eg.
EndpointConstructor
trait) and what mehods to have for it.Closes #414
Closes #2096