Add a builder for arbiter + alive method #557
Open
+153
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sytten
changed the title
|
LGTM from a quick look but needs a manual rebase (which I don't have perms to do on this PR). |
Sytten
force-pushed
the
ef-arbiter-builder
branch
from
aecb6e7
to
4a6322b
Compare
|
@robjtede Sorry it took forever to rebase, its done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Feature
PR Checklist
Check your PR fulfills the following:
Overview
Builder
This adds a builder for the arbiter, allowing more customization of the thread used by the arbiter.
The first customizable I added was the name, this allows us to differentiate the different arbiters better since they are not all used for the same purpose.
Alive
I also added an
alivemethod on the arbiter so the caller can try to detect dead arbiters before sending it a future since it consumes it. Otherwise you need to have a clone future which is not good most of the time.